-
Notifications
You must be signed in to change notification settings - Fork 18
HTTP API for Measure Conversion #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the easy part. Getting the answer is the hard part.
api.bs
Outdated
| <div class=example id=ex-measure-conversion-header> | ||
| This is the HTTP equivalent of <a href=#ex-measure-conversion>the JavaScript `measureConversion` example</a>: | ||
| <xmp highlight=http> | ||
| Measure-Conversion: aggregation-service="https://aggregator.example/tee", histogram-size=20, epsilon=1.0, lookback-days=14, impression-sites=("publisher.example" "other.example"), impression-callers=("ad-tech.example"), match-values=(2), credit=(0.25 0.25 0.5), value=3, max-value=7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of aggregation-service is not something that can be looked up through this API. That makes this far less reliable than the JS API, which at least can adapt.
Another thing that needs to be noted clearly is that this doesn't let you have multiple Measure-Conversion fields. If there are multiple conversions, then maybe a redirect chain will allow those to be logged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of
aggregation-serviceis not something that can be looked up through this API. That makes this far less reliable than the JS API, which at least can adapt.
If we thought it important, we could advertise the set of aggregation services in a Client-Hints-like request header.
Another thing that needs to be noted clearly is that this doesn't let you have multiple
Measure-Conversionfields. If there are multiple conversions, then maybe a redirect chain will allow those to be logged.
True, though that caveat also applies to the existing Save-Impression header. We have an example use case for recording multiple impressions simultaneously in #222.
41307b2 to
c8a91ed
Compare
|
Discussed in the Oct 14 call - let's wait to merge until we have support for sending the report. |
I think we need to deal with #189 first. |
Preliminary work for #31; still need to specify when this header is processed (#189) and how the report destination is configured.
Preview | Diff